This repository was archived by the owner on Aug 4, 2022. It is now read-only.
Install workload in scale unit even if found Ready#128
Merged
AndreasHassing merged 1 commit intomainfrom Jan 7, 2022
Merged
Conversation
Omaaarz
reviewed
Jan 7, 2022
|
|
||
| foreach (WorkloadInstance workloadInstance in workloadInstances) | ||
| { | ||
| if (await WorkloadInstanceManager.IsWorkloadInstanceInReadyState(scaleUnitAosClient, workloadInstance)) |
Contributor
There was a problem hiding this comment.
I guess one of the reasons we might have had this reason, is that if in the previous run couple of workloads were installed, we just need to install only the remaining ones.
Not sure if that will cause us problems?
Contributor
Author
There was a problem hiding this comment.
As long as a single run of workload installation succeeds, we're fine.
The new behavior will act as a workload upgrade; can that cause problems, you think?
Contributor
There was a problem hiding this comment.
On a second thought, it shouldn't be causing problems. At least, this will save us the workarounds we are doing now.
Omaaarz
approved these changes
Jan 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to install workloads when they are in Ready state in Scale unit, otherwise upgrades and movement to spoke can cause problems. Since there is no real workload versioning in the dev tools, we need to just overwrite on every install as we can't know what has changed without introspecting the hub workload versus what is installed in the scale unit.
#patch
Fixes #126.